Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sitegen: Fix Site Logo Data #56

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Sitegen: Fix Site Logo Data #56

merged 2 commits into from
Feb 28, 2024

Conversation

arunshenoy99
Copy link
Member

No description provided.

@arunshenoy99 arunshenoy99 added the Code Review Code Review label Feb 27, 2024
officiallygod
officiallygod reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about update_data in FlowService? Ig it was working earlier cause it was currentData.data.siteLogo but will it now?

@arunshenoy99 arunshenoy99 added Ready to merge The PR is Code Reviewed and Tested and can be merged. and removed Code Review Code Review labels Feb 28, 2024
@arunshenoy99 arunshenoy99 merged commit dad5dc2 into main Feb 28, 2024
1 check passed
@arunshenoy99 arunshenoy99 deleted the fix/site-logo-data branch February 28, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officiallygod officiallygod officiallygod approved these changes

Assignees
No one assigned
Labels
Ready to merge The PR is Code Reviewed and Tested and can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunshenoy99 @officiallygod