Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Store or Products Pages to the WooCommerce shop page #107

Merged
merged 14 commits into from
Sep 25, 2024
Merged

Set Store or Products Pages to the WooCommerce shop page #107

merged 14 commits into from
Sep 25, 2024

Conversation

ramyakrishnai
Copy link
Contributor

Proposed changes

Jira: https://jira.newfold.com/browse/PRESS0-1575

  • Updating woocommerce_shop_page_id option to generated product page id & woocommerce_shop_page_id to yes to reflects the products in page.
Screen.Recording.2024-07-25.at.2.49.15.PM.mov

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@ramyakrishnai ramyakrishnai self-assigned this Jul 26, 2024
@ramyakrishnai ramyakrishnai added the Code Review Code Review label Jul 26, 2024
@arunshenoy99 arunshenoy99 added QA Ready for QA and removed Code Review Code Review labels Jul 30, 2024
@ramyakrishnai ramyakrishnai added Ready to merge The PR is Code Reviewed and Tested and can be merged. and removed QA Ready for QA labels Sep 24, 2024
@officiallygod officiallygod merged commit 4444dcd into main Sep 25, 2024
@officiallygod officiallygod deleted the fix/press0-1575 branch September 25, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees

@ramyakrishnai ramyakrishnai

Labels
Ready to merge The PR is Code Reviewed and Tested and can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramyakrishnai @arunshenoy99 @officiallygod