Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert less specific onboarding url #32

Merged
merged 1 commit into from
Nov 6, 2024
Merged

assert less specific onboarding url #32

merged 1 commit into from
Nov 6, 2024

Conversation

circlecube
Copy link
Member

The ai test asserts the onboarding url, but this URL depends on some capabilities, so we can be less specific in the URL assertion.

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

The ai test asserts the onboarding url, but this URL depends on some capabilities, so we can be less specific in the URL assertion.
@circlecube circlecube requested a review from abhijitb November 5, 2024 21:58
@circlecube circlecube self-assigned this Nov 5, 2024
@circlecube circlecube requested a review from wpscholar November 5, 2024 23:01
@circlecube circlecube merged commit 9cc5b56 into main Nov 6, 2024
6 checks passed
@circlecube circlecube deleted the fix/ai-test-url branch November 6, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants