Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricting calling of cf service everytime when website is loaded #45

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

ramyakrishnai
Copy link
Contributor

Proposed changes

  • Saving the insta api key in db by encrypting and decryting while getting from db.
  • If the value is not present in db calling it from the service and saving the encrypted value in db.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Member

@circlecube circlecube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on a live site and see that it's not requesting keys every page load anymore.

Thanks @ramyakrishnai

@circlecube
Copy link
Member

We're doing an out of cycle release today, I'll merge this in and tag a release so migrations can still get a key when needed and function as expected again.

@circlecube circlecube merged commit a0b5df7 into main Jun 20, 2024
1 check passed
@circlecube circlecube deleted the fix/fetching_key_everytime branch June 20, 2024 19:34
@circlecube circlecube mentioned this pull request Jun 20, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants