Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press0 1140 | Explore BH integration with InstaWP site migration solution for self-service WP site migration #1

Merged
merged 14 commits into from
Apr 25, 2024

Conversation

ramyakrishnai
Copy link
Contributor

Proposed changes

https://jira.newfold.com/browse/PRESS0-1140

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Member

@wpscholar wpscholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure this PR might still be in flux, but here's my current feedback.

.github/workflows/lint-php.yml Outdated Show resolved Hide resolved
.github/workflows/publish-package.yml Outdated Show resolved Hide resolved
if: "!! env.GIT_DIFF"

- name: Cache Composer vendor directory
uses: actions/cache@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action is at version 4. We should add a dependabot.yml file to help us stay on top of these dependencies. See https://github.com/newfold-labs/wp-module-coming-soon/blob/main/.github/dependabot.yml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, I forgot to add it. I'll add it now.

.github/workflows/satis-update.yml Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
phpcs.xml Outdated Show resolved Hide resolved
src/components/DashboardMigrate.js Outdated Show resolved Hide resolved
src/components/DashboardMigrate.js Outdated Show resolved Hide resolved
src/components/DashboardMigrate.js Outdated Show resolved Hide resolved
src/components/DashboardMigrate.js Outdated Show resolved Hide resolved
@ramyakrishnai ramyakrishnai requested a review from wpscholar April 23, 2024 14:19
Copy link
Member

@wpscholar wpscholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a dependabot.yml file and make sure linting passes, then we can get this merged.

@ramyakrishnai ramyakrishnai requested a review from wpscholar April 24, 2024 12:41
Copy link
Member

@wpscholar wpscholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's merge this.

@ramyakrishnai ramyakrishnai merged commit e28730c into main Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants