-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Press0 1140 | Explore BH integration with InstaWP site migration solution for self-service WP site migration #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure this PR might still be in flux, but here's my current feedback.
.github/workflows/lint-php.yml
Outdated
if: "!! env.GIT_DIFF" | ||
|
||
- name: Cache Composer vendor directory | ||
uses: actions/cache@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action is at version 4. We should add a dependabot.yml
file to help us stay on top of these dependencies. See https://github.com/newfold-labs/wp-module-coming-soon/blob/main/.github/dependabot.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramyakrishnai Let's also add a .github/dependabot.yml
file like the one here: https://github.com/newfold-labs/wp-module-coming-soon/blob/main/.github/dependabot.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies, I forgot to add it. I'll add it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a dependabot.yml
file and make sure linting passes, then we can get this merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Let's merge this.
Proposed changes
https://jira.newfold.com/browse/PRESS0-1140
Type of Change
Checklist
Further comments