-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Modal styles/UX #40
Conversation
make the modal more responsive give headline line-height and remove letter-spacing so it usually fits on one line alphasort css rules (sorry for the noise)
…splay over other wp-admin elements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
@@ -137,7 +141,6 @@ const Modal = ( { | |||
}, | |||
} ); | |||
setPluginStatus( 'completed' ); | |||
showModal( false ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might not close the modal if there is an internal redirect, If that is okay it should be fine.
For example we are on: {siteUrl}/wp-admin/admin.php?page=bluehost#/home
and we install the WonderCart Plugin with the CTA: DATA It redirects us to an internal page and I am not sure if the modal closes in that case.
Proposed changes
This updates a few visual and UX issues with the installer modal:
Type of Change
Video
Checklist
Further comments