Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove value as it's unnessecary and breaks php older than 8 #39

Merged
merged 1 commit into from
Oct 23, 2024
Merged

remove value as it's unnessecary and breaks php older than 8 #39

merged 1 commit into from
Oct 23, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

Fixing a line of PHP that was breaking older php.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested a review from wpscholar October 23, 2024 23:05
@circlecube circlecube self-assigned this Oct 23, 2024
@circlecube circlecube merged commit 7209d59 into main Oct 23, 2024
3 checks passed
@circlecube circlecube deleted the fix/php-issue branch October 23, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpscholar wpscholar wpscholar approved these changes

Assignees

@circlecube circlecube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@circlecube @wpscholar