Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/fix modal bugs #33

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Enhance/fix modal bugs #33

merged 3 commits into from
Oct 21, 2024

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Oct 21, 2024

Fixes

  • Clicking the help link in the installer modal does not close the modal after taking them to the help page.
  • Redirect takes you to homepage with /undefined in the URL instead of to the href/data attribute URL

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@officiallygod officiallygod added the in-progress The PR is currently in development label Oct 21, 2024
@officiallygod officiallygod self-assigned this Oct 21, 2024
@officiallygod
Copy link
Member Author

@wpscholar @circlecube I have added a hook that can be used to enqueue the installer scripts wherever the solutions module might be used so that we can prevent any unnecessary enqueue in Wordpress pages where this might never be used.

@officiallygod officiallygod removed the in-progress The PR is currently in development label Oct 21, 2024
@circlecube circlecube merged commit 8a0f103 into solutions Oct 21, 2024
3 checks passed
@circlecube circlecube deleted the enhance/fix-modal-bugs branch October 21, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants