Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Listener in Installer Module for Premium Plugin Installation #23

Merged
merged 15 commits into from
Oct 8, 2024

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Oct 7, 2024

Proposed changes

This PR introduces functionality to read specific data attributes (data-nfd-installer-plugin-provider, data-nfd-installer-plugin-slug, and data-nfd-installer-plugin-activate) from the plugin and, based on these attributes, triggers the installer module.

The installer module interacts with the Plugin Library Service (PLS) to automatically install and optionally activate the specified plugins. This enhancement streamlines plugin installation by allowing seamless execution based on defined HTML data attributes.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@officiallygod officiallygod added the in-progress The PR is currently in development label Oct 7, 2024
@officiallygod officiallygod self-assigned this Oct 7, 2024
@officiallygod officiallygod changed the base branch from main to solutions October 7, 2024 10:13
@officiallygod officiallygod removed the in-progress The PR is currently in development label Oct 7, 2024
@officiallygod officiallygod changed the base branch from solutions to enhance/plugin-upgrader October 8, 2024 07:32
Base automatically changed from enhance/plugin-upgrader to solutions October 8, 2024 08:20
@arunshenoy99 arunshenoy99 merged commit e932c7d into solutions Oct 8, 2024
2 of 3 checks passed
@arunshenoy99 arunshenoy99 deleted the enhance/data-plugin-install-script branch October 8, 2024 13:50
@arunshenoy99 arunshenoy99 mentioned this pull request Oct 18, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants