Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP warnings #18

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Fix PHP warnings #18

merged 1 commit into from
Mar 19, 2024

Conversation

arunshenoy99
Copy link
Member

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixes

[19-Mar-2024 07:42:28 UTC] PHP Warning:  Undefined array key "yith-product-search-extended" in /Users/arun.sh/Desktop/WordPress/repos/plugins/bluehost-wordpress-plugin/vendor/newfold-labs/wp-module-installer/includes/Services/PluginInstaller.php on line 316
[19-Mar-2024 07:42:28 UTC] PHP Warning:  Trying to access array offset on value of type null in /Users/arun.sh/Desktop/WordPress/repos/plugins/bluehost-wordpress-plugin/vendor/newfold-labs/wp-module-installer/includes/Services/PluginInstaller.php on line 316

And

Deprecated: Return type of
NewfoldLabs|WP|Module\Installer\Models\PriorityQueue::compare($priority1, $priority2) should
either be compatible with SplPriorityQueue::compare (mixed $priority1, mixed $priority2): int, or
the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in
/app/wordpress/content/plugins/bluehost-wordpress-plugin/vendor/newfold-labs/wp-module-
installer/includes/Models/PriorityQueue.php on line 16

Copy link
Member

@officiallygod officiallygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me!

@arunshenoy99 arunshenoy99 requested a review from wpscholar March 19, 2024 09:36
@arunshenoy99 arunshenoy99 merged commit 26e0440 into main Mar 19, 2024
2 checks passed
@arunshenoy99 arunshenoy99 deleted the fix/deprecated-warnings branch March 19, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants