Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/helpcenter blank feedback button windows #52

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

ajayadav09
Copy link
Contributor

@ajayadav09 ajayadav09 commented Jul 29, 2024

Proposed changes

Bug Issue : Clicking on the Feedback buttons alternatively resulted into helpcenter going blankon Windows OS.

The error could be related to the usage of <>😭</> within the button. It is not able to remove the child element from the DOM in Windows. React might not be able to handle the html entities in fragment components correctly within a button component, especially when the conditionals and entities are involved. Have wrapped it in a span element so it considers the span as a child element.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

The error could be related to the usage of <>&#128557;</> within the button. It is not able to remove the child element from the DOM windows.  React might not be able to handle the html entities in  fragment components correctly within a button component, especially when the conditionals and entities are involved. Have wrapped it in a span element so it considers the span as a child element.
@ajayadav09 ajayadav09 added the In Progress This is in Development label Jul 30, 2024
@officiallygod officiallygod removed the In Progress This is in Development label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants