Set up help center feature #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
circlecube
requested review from
abhijitb,
wpscholar,
arunshenoy99 and
amartya-dev
|
See PRESS1-317 & PRESS1-314 |
wpscholar
requested changes
May 24, 2024
composer.json
Outdated
| }, | ||
| "autoload": { | ||
| "psr-4": { | ||
| "NewfoldLabs\\WP\\Module\\HelpCenter\\": "includes" | ||
| }, | ||
| "files": [ | ||
| "includes/HelpCenterFeature.php", |
There was a problem hiding this comment.
@circlecube This line is unnecessary since the class will be autoloaded using PSR-4 from the line above.
Suggested change
| "includes/HelpCenterFeature.php", |
wpscholar
reviewed
May 24, 2024
includes/HelpCenterFeatureHooks.php
Outdated
| } | ||
|
|
||
| // Do not load if `canAccessHelpCenter` capability is not true | ||
| $capability = new SiteCapabilities(); |
There was a problem hiding this comment.
Thanks for catching, should be fixed now.
abhijitb
reviewed
May 27, 2024
* main: updating wp-module-ai to 1.1.9 updating typesense search params # Conflicts: # composer.json # composer.lock
abhijitb
approved these changes
May 29, 2024
wpscholar
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This integrates the features module with the help center. It will allow users to toggle the feature on/off in the plugin settings. The features module changes the way a module is loaded, replacing the module loader/register method with a feature class and instantiate method which kicks the module off. If it is disabled the installation will not run. Integrating with the new feature module is a clean way to only load this module code when it is enabled and wraps everything into a features API that can be used by the plugins (and even other modules).
This also handles the optional loading for onboarding screens.
Upon merge, the idea is that this will be a major version release (2.x) since it changes the way the module is loaded and will need some attention when updating in the plugin. Ideally, we can also add some tests to that release to ensure the feature toggle is functional.
Type of Change
Checklist
Further comments