move constants that dont require container to bootstrap

newfold-labs · May 24, 2024 · 8b7a315 · 8b7a315
1 parent f5e3a0e
commit 8b7a315
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/bootstrap.php b/bootstrap.php
@@ -2,6 +2,11 @@
 
 namespace NewfoldLabs\WP\Module\HelpCenter;
 
+// Define global constants
+define( 'NFD_HELPCENTER_DIR', __DIR__ );
+define( 'NFD_HELPCENTER_BUILD_DIR', __DIR__ . '/build/' );
+
+// Register the HelpCenterFeature class in the features filter
 if ( function_exists( 'add_filter' ) ) {
 	add_filter(
 		'newfold/features/filter/register',

diff --git a/includes/HelpCenterFeature.php b/includes/HelpCenterFeature.php
@@ -41,8 +41,6 @@ public function initialize() {
 				function () {
 					$container = getContainer();
 					define( 'NFD_HELPCENTER_PLUGIN_DIRNAME', dirname( $container->plugin()->basename ) );
-					define( 'NFD_HELPCENTER_DIR', __DIR__ );
-					define( 'NFD_HELPCENTER_BUILD_DIR', __DIR__ . '/build/' );
 					define( 'NFD_HELPCENTER_PLUGIN_URL', $container->plugin()->url );
 					new HelpCenter( $container );
 					// Define the brand