add canToggle filters for features #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a generic and feature specific filter
wpscholar
requested changes
May 20, 2024
includes/Feature.php
Outdated
| apply_filters( | ||
| // generic canToggle filter | ||
| 'newfold/features/filter/canToggle', | ||
| current_user_can( 'manage_options' ) |
There was a problem hiding this comment.
@circlecube Given that the idea was that someone would override the canToggleFeature method, perhaps we should create a separate, private method that handles the filters and just have this method handle the permission logic.
* main: add an onInit hook add before and after hooks for enable and disable methods
wpscholar
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a generic and feature-specific canToggle filter
Proposed changes
Type of Change
Checklist
Further comments