Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced the time interval with event listener and endpoint change #41

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

ramyakrishnai
Copy link
Contributor

@ramyakrishnai ramyakrishnai commented Jan 22, 2025

Proposed changes

  • Instead of calling details method in setInterval with a event listener to call a details api only it received meesage when the window is closed

  • there is a wrong api being called to get the token which is giving 404 error, when clicking on Facebook, changed it to the actual one.

  • Screen.Recording.2025-01-23.at.10.57.51.AM.mov

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube
Copy link
Member

@ramyakrishnai can you please add a description to this PR detailing what the change does? Also missing screenshots or videos or tests.

@circlecube circlecube mentioned this pull request Jan 24, 2025
14 tasks
@circlecube circlecube merged commit 6a5df00 into newfold-labs:main Jan 24, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants