PRESS4-430, PRESS4-435 && PRESS4-430 #3
Conversation
Facebook login method2
…to get profile details
Add state to button
| { | ||
| $hiive_token = HiiveConnection::get_auth_token(); | ||
| $hash_token = get_option('nfd_fb_hash_hiive_token'); | ||
| $encryoted_token = null; |
There was a problem hiding this comment.
I just noticed we have a typo here. It will still work, but probably should fix.
| update_option('nfd_fb_details', $FacebookData); | ||
| return array($FacebookData); | ||
| } | ||
| return 'token not found!'; |
There was a problem hiding this comment.
This looks to have a different return type than everything else. We're returning an array on success or an array with an error property on error, except here. We should probably be returning a WP_Error object for errors. This way, we can easily check for is_wp_error().
includes/services/UtilityService.php
Outdated
| UtilityService::storeTokenInCookie($details); | ||
| } | ||
|
|
||
| $encrpt = new Encryption(); |
includes/services/UtilityService.php
Outdated
| { | ||
| $token = json_encode($token); | ||
| // setting cookie for 2 months | ||
| setcookie('fb_access_token', $token, time() + (60 * 60 * 24 * 30 * 2)); |
There was a problem hiding this comment.
We should use the built-in constants to make this more human-readable and less prone to error
| setcookie('fb_access_token', $token, time() + (60 * 60 * 24 * 30 * 2)); | |
| setcookie('fb_access_token', $token, time() + (MONTH_IN_SECONDS * 2)); |
includes/services/UtilityService.php
Outdated
| */ | ||
| public static function deleteTokenFromCookie() | ||
| { | ||
| setcookie('fb_access_token', '', time() - (60 * 60 * 24 * 30 * 2)); |
There was a problem hiding this comment.
| setcookie('fb_access_token', '', time() - (60 * 60 * 24 * 30 * 2)); | |
| setcookie('fb_access_token', '', time() - (MONTH_IN_SECONDS * 2)); |
| },height=${window.innerHeight / 2 + 200},top=200,left=200` | ||
| ); | ||
|
|
||
| const intervalId = setInterval(async function () { |
There was a problem hiding this comment.
@ramyakrishnai Still curious about this one.
| $hash_token = get_option('nfd_fb_hash_hiive_token'); | ||
| $encryoted_token = null; | ||
| if (!$hash_token) { | ||
| $encryoted_token = $hiive_token ? UtilityService::encrypt_token($hiive_token) : ''; |
There was a problem hiding this comment.
@ramyakrishnai This isn't really a hashed token. Since we are only using this as a lookup value, we should use an irreversible hash here. We just need to run the token through the wp_hash() function.
There was a problem hiding this comment.
Hi, @wpscholar the setInterval, we're using to get notified when the pop up is closed.So, we can do a api call when it is closed to get the user details
Thanks!
Handle Popup blocker scenario for FB login form
We need to move helper functions to get user profile details, images etc to PHP from Javascript.
Encrypt/Decrypt Facebook access_token
Moved hiive token generation logic to the wp-module-facebook module.
Checking access_token validity logic.
Notification added to notify the customer once Facebook is connected.
Added encryption to fb_token in facebook.
Moved helper functions logic to backend.
Jira Links