Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated failing test for wonderHelp after Migration #395

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

ajayadav09
Copy link
Contributor

@ajayadav09 ajayadav09 commented Dec 12, 2024

As the input is being reset after the search. The cypress test in ecomm module fails as it looks for a persisted value in the input box. This change will fix that.
https://jira.newfold.com/browse/PRESS6-73

Proposed changes

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

ajayadav09 and others added 4 commits December 12, 2024 21:51
As the input is being reset after the search. The cypress test in ecomm module fails as it looks for a persisted value in the input box. This change will fix that.

Co-Authored-By: Emanuela Antonina Castorina  <[email protected]>
@ramyakrishnai ramyakrishnai merged commit 787871b into trunk Dec 16, 2024
2 of 4 checks passed
@ramyakrishnai ramyakrishnai deleted the PRESS6-73-fix-cypress-test branch December 16, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants