Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/tests with plugin uninstall commands #393

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

This updates a support method used in cypress tests. Currently, it uninstalls all plugins except those listed in the exclude list. I'm updating it to only uninstall the plugins that the test installs (Woo and the YITH payment plugins that are automatically installed with it). The module shouldn't have to keep a list of plugins to exclude.

I ran into issues with the bluehost plugin migration where even though the build slug will not be changed, in the testing env it can show up differently. This change fixes those issues and also will be more stable. The tests should clean up after themselves and not attempt to uninstall everything anyways - that approach is more brute force than we needed (and I think I'm to blame for it).

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

…lugins

this is giving issues if being used in a plugin with a different slug than the ones previously listed. its better to only uninstall the plugins that tests install rather than everything
also clean up some uses so the tests clean up after themselves properly
@circlecube
Copy link
Member Author

I see Crazy Domains tests are failing, but it is the coming soon tests. They should be updated by this PR newfold-labs/wp-module-coming-soon#44 when it gets merged and updated in that plugin. Otherwise things look good for tests.

@circlecube circlecube merged commit 9c423f7 into trunk Dec 16, 2024
2 of 4 checks passed
@circlecube circlecube deleted the update/tests-with-plugin-uninstall-commands branch December 16, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants