Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Empty script being loaded from the e-commerce module #348

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

aratidgr8
Copy link
Contributor

Proposed changes

PRESS0-1968 : The Ecommerce module is loading the root plugin directory as a script.
JIRA: https://jira.newfold.com/browse/PRESS0-1968

Removed

\wp_register_script(
  'nfd-ecommerce-dependency',
  NFD_ECOMMERCE_PLUGIN_URL,
  array_merge( $asset['dependencies'], array() ),
  $asset['version']
);

Instead registered, 'vendor/newfold-labs/wp-module-ecommerce/build/index.js' file.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@aratidgr8 aratidgr8 merged commit 2aeb447 into trunk Sep 5, 2024
3 of 6 checks passed
@aratidgr8 aratidgr8 deleted the PRESS0-1968 branch September 5, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants