-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple tests failing in all brand release PRs cypress tests and matrix workflows. #334
Conversation
@circlecube we might not see CD tests passing here, once we create a PR to plugin we should be seeing the test pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work, but it would be more stable to use contain
rather than equal
for the URL check. That way we can check that it contains https://my.yoast.com/signup?redirect_to=https://academy.yoast.com/courses/
and not worry about the rest of the params per brand.
Would also prefer to include a comment about why a test is being skipped. When we look at this later it will be good to know why the skip is in place for CD. We should always be clear why it is skipped so we can unskip it if that condition is no longer relevant.
Added possible solutions for multiple issues described here PRESS0-1673 and addressed review comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine
Since reviewer is OOO, to take the process forward. Review comments are addressed.
Proposed changes
Detailed description of failures and their fixes can be found in JIRA: PRESS0-1673
Type of Change
Checklist
Further comments