Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple tests failing in all brand release PRs cypress tests and matrix workflows. #334

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

sangeetha-nayak
Copy link
Contributor

@sangeetha-nayak sangeetha-nayak commented Jul 3, 2024

Proposed changes

  1. Update utm_medium param value to crazy_plugin
  2. Skip Razorpay payment processor connection test for CD brand since Razorpay is not supported for the same.
  3. Fix migration tests failing in some cypress matrix combinations of BH Release PR

Detailed description of failures and their fixes can be found in JIRA: PRESS0-1673

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@sangeetha-nayak
Copy link
Contributor Author

@circlecube we might not see CD tests passing here, once we create a PR to plugin we should be seeing the test pass.

Copy link
Member

@circlecube circlecube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work, but it would be more stable to use contain rather than equal for the URL check. That way we can check that it contains https://my.yoast.com/signup?redirect_to=https://academy.yoast.com/courses/ and not worry about the rest of the params per brand.

Would also prefer to include a comment about why a test is being skipped. When we look at this later it will be good to know why the skip is in place for CD. We should always be clear why it is skipped so we can unskip it if that condition is no longer relevant.

@sangeetha-nayak sangeetha-nayak changed the title Update utm_medium param value and skip razorpay test for CD Fix multiple tests failing in all brand release PRs cypress tests and matrix workflows. Jul 4, 2024
@sangeetha-nayak
Copy link
Contributor Author

sangeetha-nayak commented Jul 4, 2024

Added possible solutions for multiple issues described here PRESS0-1673 and addressed review comments.

Copy link
Contributor

@krsomayagi krsomayagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@sangeetha-nayak sangeetha-nayak removed the request for review from circlecube July 5, 2024 06:06
@sangeetha-nayak sangeetha-nayak dismissed circlecube’s stale review July 5, 2024 06:06

Since reviewer is OOO, to take the process forward. Review comments are addressed.

@ramyakrishnai ramyakrishnai merged commit edf5a3b into trunk Jul 5, 2024
3 of 5 checks passed
@ramyakrishnai ramyakrishnai deleted the PRESS0-1673 branch July 5, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants