post migration changes #284

ramyakrishnai · 2024-04-16T07:14:05Z

Proposed changes

Jira: https://jira.newfold.com/browse/PRESS0-1157

Post Migration steps *****
Given when the migration is successful
When customer is SSO'ed to wp-admin dashboard
Then we will need to display the following options with -> as part of "Next Steps"
"Update your Nameserver to BH"
"Connect the site to your Domain"
And on click of the -> Help Center slider shall open with information for the following questions
How do I update my nameserver to BH?
How do I connect my site to the Domain ?

Need help with these steps ? "View guide" link to https://www.bluehost.com/help

Type of Change

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices apply)

Checklist

I have read the CONTRIBUTING doc
Linting and tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

Further comments

…abs/wp-module-ecommerce into post-migration-changes

aratidgr8 · 2024-04-25T12:23:37Z

src/components/OnboardingList.js

        )}
      </Link>
    </li>
  );
 }

+const check_url_match = () => {
+  const brandName = (NewfoldRuntime?.sdk?.ecommerce?.brand_settings?.name).toLowerCase();


NewfoldRuntime?.sdk?.ecommerce Needs to updated as discussed.

currently in newfoldRuntime, we're not getting ecommerce out of sdk, only once the ecommerce is out side of sdk, we can add this change

Why can't we use NewfoldRuntime?.plugin?.brand we can also skip toLowerCase() if we use that variable.

We can't use plugin, becuase when bluehost changed it's brand like bluehost-us, hostgator_latam, at that time, this value wil not work

As discussed on call we would go split way and add a TODO

aratidgr8 · 2024-04-25T12:29:02Z

src/configs/OnboardingList.config.js

+    WordPressSdk.settings.get();
+    setIsMigrationCompleted(false);
+  });
+};
 const signUpYoastSEOAcademy = () => {
  WordPressSdk.settings.put({ yoast_seo_signup_status: true });
  AnalyticsSdk.track("next_step", "next_step_yoast_academy_clicked", data);
 };
 const brandName =
  (NewfoldRuntime?.sdk?.ecommerce?.brand_settings?.name).toLowerCase();


Avoid using NewfoldRuntime?.sdk

currently in newfoldRuntime, we're not getting ecommerce out of sdk, only once the ecommerce is out side of sdk, we can add this change

Why can't we use NewfoldRuntime?.plugin?.brand we can also skip toLowerCase() if we use that variable.

We can't use plugin, becuase when bluehost changed it's brand like bluehost-us, hostgator_latam, at that time, this value wil not work

As discussed on call we would go split way and add a TODO

aratidgr8 · 2024-04-25T12:31:24Z

src/configs/OnboardingList.config.js

+          isMigrated: (queries) => queries?.settings?.showMigrationSteps || props.isMigrationCompleted,
+        },
+
+        "data-nfdhelpcenterquery": "How do I connect my site to the Domain ?",


Translations not needed?

aratidgr8 · 2024-04-25T12:32:22Z

src/configs/OnboardingList.config.js

+          manage: () => updateSiteServers(props.setWebServersUpdated),
+        },
+
+        "data-nfdhelpcenterquery": "How do I update my nameserver to BH?",


Translations not needed?

aratidgr8 · 2024-04-25T12:33:36Z

src/configs/OnboardingList.config.js

+          isMigrated: (queries) => queries?.settings?.showMigrationSteps,
+          className: () => "nfd-bg-canvas",
+          hideCheck: () => true,
+          showText: () => <a className="nfd-underline" href="https://www.bluehost.com/help" target="_blank">View Guide</a>


Will this link be hardcoded to bluehost.com?

@ramyakrishnai plz cross-check this one as well

aratidgr8 · 2024-04-25T12:39:21Z

src/configs/OnboardingList.config.js

 const signUpYoastSEOAcademy = () => {
  WordPressSdk.settings.put({ yoast_seo_signup_status: true });
  AnalyticsSdk.track("next_step", "next_step_yoast_academy_clicked", data);
 };
 const brandName =
  (NewfoldRuntime?.sdk?.ecommerce?.brand_settings?.name).toLowerCase();

+const check_url_match = () => {


Can we avoid redundant code of constant check_url_match in src/configs/OnboardingList.config.js and src/components/OnboardingList.js

Define once in src/constants.js & import as per need.

aratidgr8 · 2024-04-25T12:42:14Z

@ramyakrishnai Please add more details in PR description.

aratidgr8 · 2024-04-26T07:13:04Z

src/components/OnboardingList.js

@@ -21,6 +22,7 @@ function OnboardingCheckListItem({ children, actions, state, ...props }) {
      className={classNames(
        "nfd-p-[2px]",
        "nfd-m-0 nfd-border-b nfd-border-line last:nfd-border-b-0",
+        state.className,


Can you pass className as props

I'm passing classname as prop which is being destructed as state from props, these values are coming from onboarding.config.js

aratidgr8 · 2024-04-26T07:14:14Z

src/components/OnboardingList.js

        )}
      </Link>
    </li>
  );
 }

+const brandName = (NewfoldRuntime?.sdk?.ecommerce?.brand_settings?.name).toLowerCase();


we use NewfoldRuntime?.plugin?.brand we can also skip toLowerCase() if we use that variable.

aratidgr8 · 2024-04-26T07:16:02Z

src/components/OnboardingScreen.js

@@ -88,18 +96,18 @@ export function OnboardingScreen({
            )}
          >
            <div className="nfd-flex nfd-flex-col nfd-justify-start nfd-items-start nfd-gap-4">
-              <Title size="2">{title}</Title>
+              <Title size="2">{isMigrationCompleted ? Text.isMigrated.title : title}</Title>


Translations need to be added when displaying title only

translations are added in the variable which is being used here

aratidgr8 · 2024-04-26T07:16:13Z

src/components/OnboardingScreen.js

              <div>
                {comingSoon ? (
                  <Alert
                    variant="warning"
                    className="nfd-text-sm nfd-bg-transparent nfd-p-0 "
                  >
-                    <span className="nfd-text-red-700">{description}</span>
+                    <span className="nfd-text-red-700">{isMigrationCompleted ? Text.isMigrated.description : description}</span>
                  </Alert>


Translations need to be added when only description is displayed

translations are added in the variable which is being used here

aratidgr8 · 2024-04-26T07:17:42Z

src/configs/OnboardingList.config.js

+    WordPressSdk.settings.get();
+    setIsMigrationCompleted(false);
+  });
+};
 const signUpYoastSEOAcademy = () => {
  WordPressSdk.settings.put({ yoast_seo_signup_status: true });
  AnalyticsSdk.track("next_step", "next_step_yoast_academy_clicked", data);
 };
 const brandName =


check if brandName variable could also be added to constants, and imported at necessary places

aratidgr8 · 2024-04-26T12:12:20Z

src/configs/OnboardingList.config.js

+          isMigrated: (queries) => queries?.settings?.showMigrationSteps,
+          className: () => "nfd-bg-canvas",
+          hideCheck: () => true,
+          showText: () => <a className="nfd-underline" href={ NewfoldRuntime.sdk.ecommerce.brand_settings.videGuideLink } target="_blank">View Guide</a>


videGuideLink This can be moved out of NewfoldRuntime.sdk.ecommerce. ?

We could create a JS constant
videGuideLink = { 'bluehost': 'https://www.bluehost.com/help', 'hostgator': 'https://www.hostgator.com/help' }

aratidgr8 · 2024-04-29T06:07:56Z

includes/Data/Brands.php

@@ -34,7 +34,7 @@ public static function get_config( Container $container ) {
 						'woocommerce_default_country' => 'AU:NSW',
 						'woocommerce_currency'        => 'AUD',
 					),
-					'wondercartBuyNow' => ''
+					'wondercartBuyNow' => '',


We were to remove all Brands.php changes right?

yeah, the changes were removed already, it's , that is changed, I'll try to remove that

post migration changes

ff2b7a8

ramyakrishnai added the WIP Work in Progress label Apr 16, 2024

ramyakrishnai and others added 9 commits April 17, 2024 21:06

updating next steps in dashboard

1eabecf

added data attribute nfdhelpcenterquery to open helpcenter

ba0e212

event added

992906d

events added

46cc423

next step updates

46c647a

Merge branch 'post-migration-changes' of https://github.com/newfold-l…

df576d2

…abs/wp-module-ecommerce into post-migration-changes

update view guide link

68455e4

steps shouldn't be visible after continue to store set up

a684936

when session expired update the db value

f7a9382

ramyakrishnai added Code Review and removed WIP Work in Progress labels Apr 25, 2024

ramyakrishnai requested review from aratidgr8 and mamatharao05 April 25, 2024 09:31

ramyakrishnai added 2 commits April 25, 2024 15:09

Merge branch 'trunk' into post-migration-changes

00b1766

changes

f7e7d22

aratidgr8 reviewed Apr 25, 2024

View reviewed changes

comments are addressed

59a266d

ramyakrishnai requested a review from aratidgr8 April 26, 2024 06:50

aratidgr8 reviewed Apr 26, 2024

View reviewed changes

comments addressed

0c318e7

ramyakrishnai requested a review from aratidgr8 April 26, 2024 07:47

changes added

60f3b2c

aratidgr8 reviewed Apr 26, 2024

View reviewed changes

using constant instead of brands.php

bbea715

aratidgr8 reviewed Apr 29, 2024

View reviewed changes

remove ,

20cd20b

aratidgr8 previously approved these changes Apr 29, 2024

View reviewed changes

ramyakrishnai assigned ajayadav09, manikantakailasa and ramyakrishnai Apr 29, 2024

aratidgr8 added Do not merge and removed Code Review labels Apr 29, 2024

aratidgr8 mentioned this pull request Apr 29, 2024

PRESS0-1256 Remove text dependency, Replace text identifiers with id #297

Merged

8 tasks

continue store set up disappeared, once it is completed

a1c2fa2

ramyakrishnai dismissed aratidgr8’s stale review via a1c2fa2 May 2, 2024 15:24

ramyakrishnai requested review from aratidgr8 and manikantakailasa May 3, 2024 06:26

ramyakrishnai added Code Review and removed Do not merge labels May 3, 2024

manikantakailasa previously approved these changes May 3, 2024

View reviewed changes

Merge branch 'trunk' into post-migration-changes

ee0d8a4

ramyakrishnai dismissed manikantakailasa’s stale review via ee0d8a4 May 3, 2024 09:23

manikantakailasa approved these changes May 3, 2024

View reviewed changes

ramyakrishnai merged commit 1d54767 into trunk May 3, 2024
1 of 5 checks passed

ramyakrishnai deleted the post-migration-changes branch May 3, 2024 09:24

ramyakrishnai mentioned this pull request May 3, 2024

Update eCommerce version bump and lock files updated bluehost/bluehost-wordpress-plugin#1058

Merged

8 tasks

mamatharao05 mentioned this pull request May 3, 2024

update ecommerce version bump and lock files updated newfold-labs/wp-plugin-hostgator#546

Closed

ramyakrishnai mentioned this pull request May 3, 2024

Updated ecommerce version newfold-labs/wp-plugin-hostgator#547

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

post migration changes #284

post migration changes #284

ramyakrishnai commented Apr 16, 2024 •

edited

Loading

aratidgr8 Apr 25, 2024 •

edited

Loading

ramyakrishnai Apr 26, 2024

aratidgr8 Apr 26, 2024

ramyakrishnai Apr 26, 2024

aratidgr8 Apr 26, 2024 •

edited

Loading

aratidgr8 Apr 25, 2024

ramyakrishnai Apr 26, 2024

aratidgr8 Apr 26, 2024

ramyakrishnai Apr 26, 2024

aratidgr8 Apr 26, 2024

aratidgr8 Apr 25, 2024

aratidgr8 Apr 25, 2024

aratidgr8 Apr 25, 2024

aratidgr8 Apr 26, 2024

aratidgr8 Apr 25, 2024 •

edited

Loading

aratidgr8 commented Apr 25, 2024

aratidgr8 Apr 26, 2024

ramyakrishnai Apr 26, 2024

aratidgr8 Apr 26, 2024

aratidgr8 Apr 26, 2024 •

edited

Loading

ramyakrishnai Apr 26, 2024

aratidgr8 Apr 26, 2024 •

edited

Loading

ramyakrishnai Apr 26, 2024

aratidgr8 Apr 26, 2024

aratidgr8 Apr 26, 2024 •

edited

Loading

aratidgr8 Apr 26, 2024

aratidgr8 Apr 29, 2024

ramyakrishnai Apr 29, 2024 •

edited

Loading

post migration changes #284

post migration changes #284

Conversation

ramyakrishnai commented Apr 16, 2024 • edited Loading

Proposed changes

Type of Change

Checklist

Further comments

aratidgr8 Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aratidgr8 Apr 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aratidgr8 Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

aratidgr8 commented Apr 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aratidgr8 Apr 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aratidgr8 Apr 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aratidgr8 Apr 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ramyakrishnai Apr 29, 2024 • edited Loading

Choose a reason for hiding this comment

ramyakrishnai commented Apr 16, 2024 •

edited

Loading

aratidgr8 Apr 25, 2024 •

edited

Loading

aratidgr8 Apr 26, 2024 •

edited

Loading

aratidgr8 Apr 25, 2024 •

edited

Loading

aratidgr8 Apr 26, 2024 •

edited

Loading

aratidgr8 Apr 26, 2024 •

edited

Loading

aratidgr8 Apr 26, 2024 •

edited

Loading

ramyakrishnai Apr 29, 2024 •

edited

Loading