Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS4-393 | Cypress Test Workflow fix #160

Merged
merged 100 commits into from
Nov 17, 2023
Merged

Conversation

sangeetha-nayak
Copy link
Contributor

@sangeetha-nayak sangeetha-nayak commented Oct 27, 2023

Fix Cypress Tests - tests.yml - workflow to enable cypress tests from running for every PR.

Check will be triggered for each PR created against wp-module-ecommerce and cypress tests will run against plugin with dev changes on it.

A copy of Bluehost plugin with dev changes will be uploaded as workflow artifact

A small change to fix failing bluehost-plugin.yml is also included in the PR.

- name: Setup workflow context
id: workflow
working-directory: ${{ runner.temp }}
env:
REPO: ${{ github.repository }}
REPO: "bluehost-wordpress-plugin"
Copy link
Contributor

@aratidgr8 aratidgr8 Nov 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sangeetha-nayak What happens in case of other brands, shouldn't this be generic?

})

beforeEach(()=> {
cy.visit('/wp-admin/admin.php?page=bluehost#/home')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will url will change for other brands

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done changes to support other brands

uses: actions/checkout@v4
with:
repository: bluehost/bluehost-wordpress-plugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other brands?

.wp-env.json Outdated
"WP_TESTS_DOMAIN": "localhost:8881",
"WP_TESTS_EMAIL": "[email protected]",
"WP_TESTS_TITLE": "WordPress Tests",
"WP_TESTS_TITLE": "Bluehost WordPress Plugin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generic title?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@aratidgr8 aratidgr8 self-requested a review November 17, 2023 13:41
@ramyakrishnai ramyakrishnai merged commit 9680f2d into trunk Nov 17, 2023
1 of 3 checks passed
@ramyakrishnai ramyakrishnai deleted the fix-tests-workflow branch November 17, 2023 16:40
@aratidgr8 aratidgr8 mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants