Disable coming soon upon plugin deactivation #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket aims to address this internal ticket: https://jira.newfold.com/projects/PRESS1/issues/PRESS1-122
The ticket asks that on plugin deactivation, we should:
site_launchedevent.I initially added the code to do the above entirely, but as I was testing, I found out that the data module already sends the
site_launchedevent uponmm_coming_soonvalue change to 'false' https://github.com/newfold-labs/wp-module-data/blob/main/includes/Listeners/BluehostPlugin.php#L39-L52So, just disabling coming soon is enough to send the event. However, I kept the event code on there but commented out the function call since the code in this can be used later for future events.
Open to ideas as well.