Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add i18n scripts and pot file #23

Merged
merged 2 commits into from
Dec 16, 2024
Merged

add i18n scripts and pot file #23

merged 2 commits into from
Dec 16, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

Adds i18n scripts and the pot file. We'll need add the translations before this is properly i18n-ed, but the strings are all loaded in PHP and added to the newfoldDeactivation script and js loads the strings from there, so we shouldn't need json translations for now.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested a review from wpalani December 12, 2024 20:54
@circlecube circlecube self-assigned this Dec 12, 2024
@circlecube circlecube requested a review from abhijitb December 13, 2024 15:07
@circlecube circlecube merged commit 93b7aa7 into main Dec 16, 2024
4 of 6 checks passed
@circlecube circlecube deleted the add/i18n branch December 16, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants