Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes a php notice in 8.2 #12

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fixes a php notice in 8.2 #12

merged 1 commit into from
Apr 22, 2024

Conversation

circlecube
Copy link
Member

There is a notice when a brand plugin as the builder plugin are both active. This change simply defines the property so it is not dynamically defined.

Deprecated: Creation of dynamic property NewfoldLabs\WP\Module\Deactivation\DeactivationSurvey::$strings is deprecated

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Deprecated: Creation of dynamic property NewfoldLabs\WP\Module\Deactivation\DeactivationSurvey::$strings is deprecated
@circlecube circlecube self-assigned this Apr 10, 2024
@circlecube circlecube merged commit 9c45ae7 into main Apr 22, 2024
4 of 6 checks passed
@circlecube circlecube deleted the fix/php-notice branch April 22, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants