Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module responsibilities and critical path to README #11

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Add module responsibilities and critical path to README #11

merged 2 commits into from
Apr 8, 2024

Conversation

wpalani
Copy link
Member

@wpalani wpalani commented Apr 8, 2024

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@wpalani wpalani requested review from circlecube and wpscholar April 8, 2024 03:17
wpscholar
wpscholar approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@wpscholar wpscholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one quick typo fix.

README.md Outdated Show resolved Hide resolved
@wpalani @wpscholar
Update README.md
1191bc5 
Co-authored-by: Micah Wood <[email protected]>
@wpscholar wpscholar merged commit 312caf3 into main Apr 8, 2024
2 of 6 checks passed
@wpscholar wpscholar deleted the add/module-responsibilities-doc branch April 8, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpscholar wpscholar wpscholar approved these changes

@circlecube circlecube Awaiting requested review from circlecube

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpalani @wpscholar