PRESS12-44 Added a GA event for WooPay connection.

[mamatharao05]

Proposed changes

Added a GA event for WooCommerce payment connection.
https://jira.newfold.com/browse/PRESS12-44

Type of Change

Production

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update
• Refactoring / housekeeping (changes to files not directly related to functionality)

Development

• Tests
• Dependency update
• Environment update / refactoring
• Documentation Update

Video

Checklist

• I have read the CONTRIBUTING doc
• I have viewed my change in a web-browser
• Linting and tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

[BrianHenryIE]

I took a look around and I'm not sure that this will work. Please add instructions / tests showing how it works.

The only place I see that option name is in Automattic/woocommerce-payments ... class-wc-payments-account.php#L38 which is used when calling woocommerce/woocommerce ... core-functions.php#L53 and when I follow that, I don't see update_option() anywhere.

[mamatharao05]

I took a look around and I'm not sure that this will work. Please add instructions / tests showing how it works.

The only place I see that option name is in Automattic/woocommerce-payments ... class-wc-payments-account.php#L38 which is used when calling woocommerce/woocommerce ... core-functions.php#L53 and when I follow that, I don't see update_option() anywhere.

Checking

[mamatharao05]

I took a look around and I'm not sure that this will work. Please add instructions / tests showing how it works.

The only place I see that option name is in Automattic/woocommerce-payments ... class-wc-payments-account.php#L38 which is used when calling woocommerce/woocommerce ... core-functions.php#L53 and when I follow that, I don't see update_option() anywhere.

@BrianHenryIE I have updated the hook. wcpay_account_data is the option, which gets updated when WooPay is connected. Could you please review it?

[mamatharao05]

I took a look around and I'm not sure that this will work. Please add instructions / tests showing how it works.
The only place I see that option name is in Automattic/woocommerce-payments ... class-wc-payments-account.php#L38 which is used when calling woocommerce/woocommerce ... core-functions.php#L53 and when I follow that, I don't see update_option() anywhere.

@BrianHenryIE I have updated the hook. wcpay_account_data is the option, which gets updated when WooPay is connected. Could you please review it?

@BrianHenryIE, @circlecube Could you please review?