Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow uninstall cli command to fail #49

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

circlecube
Copy link
Member

Proposed changes

Some plugins (without ecommerce module) dont install extra plugins with woo, so trying to uninstall them causes a test failure

This should fix failing tests in mojo and web plugins.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

some plugins (without ecommerce module) dont install extra plugins with woo, so trying to uninstall them causes a test failure
@circlecube circlecube self-assigned this Jan 22, 2025
wpalani
wpalani previously approved these changes Jan 23, 2025
@circlecube
Copy link
Member Author

Web tests fail because they are excluded and the workflow can't load the module-specific tests since they are excluded and that throws an error.

@circlecube circlecube merged commit a31cd92 into main Jan 23, 2025
5 of 6 checks passed
@circlecube circlecube deleted the update/woo-uninstall-test branch January 23, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants