Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated move action to use move characteristic instead of height monitoring #396

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

sroebert
Copy link
Contributor

@sroebert sroebert commented Jan 5, 2024

When moving the desk to a new position, now the move characteristic is used, instead of moving up/down and monitoring the height changes. This results in a consistent height for the desk and making sure the desk always stops at the exact same position, compared to when using height monitoring.

This matches the logic used in: https://github.com/rhyst/linak-controller

I tested it with my own desk and it works perfectly.

@sroebert sroebert force-pushed the feature/move-to-improvements branch 3 times, most recently from 8048e8f to 2d93b0c Compare January 5, 2024 10:22
@coveralls
Copy link

coveralls commented Jan 5, 2024

Coverage Status

coverage: 88.736% (+0.4%) from 88.347%
when pulling 3fa266b on sroebert:feature/move-to-improvements
into 6ab68bc on newAM:main.

… which always stops at the right height and avoids having to monitor the height
@sroebert sroebert force-pushed the feature/move-to-improvements branch from 2d93b0c to 3fa266b Compare January 5, 2024 10:24
Copy link
Owner

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The changes look good to me, I'll just test it out when I'm at my desk next then merge.

@newAM newAM merged commit 71dd926 into newAM:main Jan 14, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants