NEVISACCESSAPP-6305: Update to version 3.8.0 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tamas-toth
commented
Nov 20, 2024
tamas-toth
commented
- Update app version to 3.8.0
- Updated all Nevis specific dependencies to 3.8.0
daniel-toth-leeder
approved these changes
Nov 20, 2024
balazs-gerlei
approved these changes
Nov 20, 2024
Comment on lines
+53
to
+57
| const deviceInformation = | ||
| (await client?.localData.deviceInformation()) ?? DeviceInformationUtils.create(); | ||
| await client?.operations.registration | ||
| .username(usernameToRegister) | ||
| .deviceInformation(DeviceInformationUtils.create()) | ||
| .deviceInformation(deviceInformation) |
There was a problem hiding this comment.
❓What is the reason for this change?
There was a problem hiding this comment.
We discussed it earlier and it's a common mistake to do not reuse the already existing device information.
On the other hand if you do not reuse the already existing device information and start to use the new devices endpoint to check device information mismatches you will get a DeviceNameMismatch if multiple accounts are registered.
tamas-toth
force-pushed
the
feature/NEVISACCESSAPP-6305-Update-to-3.8.0
branch
from
c47fbf5 to
3b9b831
Compare
- Update app version to 3.8.0 - Updated all Nevis specific dependencies to 3.8.0
tamas-toth
force-pushed
the
feature/NEVISACCESSAPP-6305-Update-to-3.8.0
branch
from
3b9b831 to
390a9d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.