NEVISACCESSAPP-5966: added password authenticator with custom policy #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daniel-toth-leeder
commented
Jul 17, 2024
daniel-toth-leeder
commented
- Changed inputs of PinScreen to be secure.
- Fixed iOS only issue of keyboard hiding buttons.
- Changed inputs of PinScreen to be secure. - Fixed iOS only issue of keyboard hiding buttons.
tamas-toth
reviewed
Jul 17, 2024
daniel-toth-leeder
force-pushed
the
feature/NEVISACCESSAPP-5966-add-password-authenticator
branch
from
d25f666 to
7e13643
Compare
tamas-toth
approved these changes
Jul 17, 2024
balazs-gerlei
changed the title
Comment on lines
-287
to
+300
| await startPinChange(eligibleAccounts); | ||
| await startPinChange(eligibleAccounts.at(0)!); | ||
| } else { | ||
| // in case that there are multiple eligible accounts then we have to show the account selection screen | ||
| return selectAccount(OperationType.pinChange); | ||
| } | ||
|
|
||
| async function startPinChange(accounts: Array<Account>) { | ||
| async function startPinChange(account: Account) { | ||
| const client = ClientProvider.getInstance().client; | ||
| client?.operations.pinChange | ||
| .username(accounts.at(0)!.username) | ||
| .username(account.username) |
daniel-toth-leeder
force-pushed
the
feature/NEVISACCESSAPP-5966-add-password-authenticator
branch
from
7e13643 to
7791359
Compare
daniel-toth-leeder
force-pushed
the
feature/NEVISACCESSAPP-5966-add-password-authenticator
branch
from
7791359 to
cc4dcce
Compare
balazs-gerlei
approved these changes
Jul 18, 2024
tamas-toth
approved these changes
Jul 18, 2024
daniel-toth-leeder
deleted the
feature/NEVISACCESSAPP-5966-add-password-authenticator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.