Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEVISACCESSAPP-6316: Fix authenticator filtering #62

Merged
merged 2 commits into from
Nov 19, 2024
Merged

NEVISACCESSAPP-6316: Fix authenticator filtering #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c602d9
NEVISACCESSAPP-6316: Bump version to 3.9.0
tamas-toth Nov 19, 2024
0f0e415
NEVISACCESSAPP-6316: Fix authenticator validation
tamas-toth Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,5 +69,5 @@ flutter {

dependencies {
//noinspection GradleDynamicVersion
debugImplementation 'ch.nevis:nevis-mobile-authentication-sdk-android-debug:3.8.+'
debugImplementation 'ch.nevis:nevis-mobile-authentication-sdk-android-debug:3.9.+'
}
4 changes: 2 additions & 2 deletions ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ target 'Runner' do
use_frameworks!
use_modular_headers!

pod 'NevisMobileAuthentication-Debug', '~> 3.8.1', :configurations => ['Debug', 'Profile']
pod 'NevisMobileAuthentication', '~> 3.8.1', :configurations => ['Release']
pod 'NevisMobileAuthentication-Debug', '~> 3.9.0', :configurations => ['Debug', 'Profile']
pod 'NevisMobileAuthentication', '~> 3.9.0', :configurations => ['Release']

flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))
end
Expand Down
2 changes: 2 additions & 0 deletions lib/domain/validation/authenticator_validator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,10 @@ class AuthenticatorValidatorImpl implements AuthenticatorValidator {
// Do not display:
// - policy non-compliant authenticators (this includes already registered authenticators)
// - not hardware supported authenticators
// - not OS supported authenticators
// - prefer Biometrics authenticator on Android
return authenticator.isSupportedByHardware &&
authenticator.isSupportedByOs &&
await context.isPolicyCompliant(authenticator.aaid) &&
await _filterAndroidFingerprintIfNecessary(context, authenticator);
});
Expand Down
4 changes: 2 additions & 2 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: nevis_mobile_authentication_sdk_example_app_flutter
description: A new Flutter project.
version: 3.8.0+1
version: 3.9.0+1

# The following line prevents the package from being accidentally published to
# pub.dev using `flutter pub publish`. This is preferred for private packages.
Expand Down Expand Up @@ -35,7 +35,7 @@ dependencies:
dio_cookie_manager: ^3.1.1
cookie_jar: ^4.0.8
permission_handler: ^11.3.1
nevis_mobile_authentication_sdk: '>=3.8.0 <3.9.0'
nevis_mobile_authentication_sdk: '>=3.9.0 <3.10.0'

dev_dependencies:
flutter_test:
Expand Down