Feature/nevisaccessapp 6287 multi user transaction confirmation fixes #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…action confirmation and account selector when there are multiple registered accounts
…on Confirmation screens are shown: the former now displayed before the latter - Transaction Confirmation screen now only deals with a single Account as that should be selected before that - Transaction Confirmation message is passed along Account Selection now - Simplified/clarified logic in AccountSelectorImpl - Add TransactionConfirmationResponse and TransactionConfirmationUseCase and its implementation, the former is used by AccountSelectorImpl and the latter is used by SelectAccountViewModel to show transaction confirmation when a message is received
tamas-toth
approved these changes
Nov 8, 2024
...java/ch/nevis/exampleapp/coroutines/domain/model/response/TransactionConfirmationResponse.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/ch/nevis/exampleapp/coroutines/domain/usecase/TransactionConfirmationUseCase.kt
Outdated
Show resolved
Hide resolved
...ain/java/ch/nevis/exampleapp/coroutines/domain/usecase/TransactionConfirmationUseCaseImpl.kt
Outdated
Show resolved
Hide resolved
...oroutines/ui/transactionConfirmation/parameter/TransactionConfirmationNavigationParameter.kt
Show resolved
Hide resolved
…and require the account to exist - Now that transaction confirmation is after Account Selection, it should always be determined at this point
laszlo-domonkos
approved these changes
Nov 8, 2024
balazs-gerlei
deleted the
feature/NEVISACCESSAPP-6287-multi-user-transaction-confirmation-fixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.