Skip to content

Commit

Permalink
[HUDI-4130] Remove the upgrade/downgrade for flink #initTable apache#…
Browse files Browse the repository at this point in the history
…5642 0.11有tryUpgrade
  • Loading branch information
neverdizzy committed Jun 7, 2022
1 parent 1a58a17 commit aa80dea
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -420,24 +420,23 @@ protected HoodieTable<T, List<HoodieRecord<T>>, List<HoodieKey>, List<WriteStatu
}

/**
* [HUDI-4130] Remove the upgrade/downgrade for flink #initTable #5642
* Upgrade downgrade the Hoodie table.
*
* <p>This action should only be executed once for each commit.
* The modification of the table properties is not thread safe.
*/
public void upgradeDowngrade(String instantTime, HoodieTableMetaClient metaClient) {
// HoodieTableMetaClient metaClient = createMetaClient(true);
new UpgradeDowngrade(metaClient, config, context, FlinkUpgradeDowngradeHelper.getInstance())
.run(HoodieTableVersion.current(), instantTime);
}

// public void upgradeDowngrade(String instantTime) {
// HoodieTableMetaClient metaClient = createMetaClient(true);
// public void upgradeDowngrade(String instantTime, HoodieTableMetaClient metaClient) {
// // HoodieTableMetaClient metaClient = createMetaClient(true);
// new UpgradeDowngrade(metaClient, config, context, FlinkUpgradeDowngradeHelper.getInstance())
// .run(HoodieTableVersion.current(), instantTime);
// .run(HoodieTableVersion.current(), instantTime);
// }

public void upgradeDowngrade(String instantTime) {
HoodieTableMetaClient metaClient = createMetaClient(true);
new UpgradeDowngrade(metaClient, config, context, FlinkUpgradeDowngradeHelper.getInstance())
.run(HoodieTableVersion.current(), instantTime);
}

/**
* Clean the write handles within a checkpoint interval.
* All the handles should have been closed already.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -361,8 +361,8 @@ private void initInstant(String instant) {
startInstant();
// upgrade downgrade
// [HUDI-4130] Remove the upgrade/downgrade for flink #initTable #5642
this.writeClient.upgradeDowngrade(this.instant, this.metaClient);
// this.writeClient.upgradeDowngrade(this.instant);
// this.writeClient.upgradeDowngrade(this.instant, this.metaClient);
this.writeClient.upgradeDowngrade(this.instant);
}, "initialize instant %s", instant);
}

Expand Down

0 comments on commit aa80dea

Please sign in to comment.