Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3132
Replaces the existing licensing exchange with a single PDU saying the server will not issue a license.
This is necessary for clients on FIPS-compliant systems, as these are unable to decode the licensing exchange PDUs, due to outdated cyphers in the licensing PDUs.
As far as FIPS mode goes, this is tested with xfreerdp 2.11.2 on Alma 9 in FIPS mode connecting to Ubuntu with fips configured in
/etc/xrdp/xrdp.ini
. Command isxfreerdp +fipsmode /v:<host>
. The/etc/xrdp/xrdp.ini
config is actually irrelevant as in any case the connection needs to take place over TLS because of #2266.Without this change the connection fails with:-
@akallabeth - With FreeRDP 3.5.1 I'm getting the following warning sending an empty BLOB in the license error PDU:-
Revised code is now here:-
I'm pretty sure I'm standards-compliant with this, but I've been wrong about that before. I'd appreciate your comment on that.