Update handling of scale factor #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nexarian
force-pushed
the
update_scaling_factor_handling
branch
from
e00e78a to
6a596bb
Compare
Looking at 2.2.2.2.1 DISPLAYCONTROL_MONITOR_LAYOUT (https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-rdpedisp/ea2de591-9203-42cd-9908-be7a55237d1c), the way we were handling it was slightly off. device_scale_factor and desktop_scale_factor are interdependent. If either one is out of spec, both are set to default. That wasn't how it was previously being handled.
Nexarian
force-pushed
the
update_scaling_factor_handling
branch
from
6a596bb to
07dbd0e
Compare
|
@Nexarian Please keep in mind to update NEWS in wiki after you merge something. It is draft release note for the next release. |
|
Ditto that. I find it a lot easier to update the NEWS when you do the merge rather than trying to pick your way through a series of changes you barely remember before a release to get a release note together. Maybe that's just me and my memory. |
|
All I needed to do here was update the wiki to add the PR: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at 2.2.2.2.1 DISPLAYCONTROL_MONITOR_LAYOUT (https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-rdpedisp/ea2de591-9203-42cd-9908-be7a55237d1c),
the way we were handling it was slightly off. device_scale_factor and
desktop_scale_factor are interdependent. If either one is out of spec,
both are set to default. That wasn't how it was previously being
handled.