This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Fix generation of changelog during release:prepare #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using auto-changelog's `--package` option, which does
not work with Lerna monorepos, since there is no version in the repo root
`package.json`. Now the version is instead read from `lerna.json`.
In addition, `SKIP_CHANGELOG` has been removed, since:
(a) using environment variables in package.json scripts makes them
incompatible with Windows
(b) we now use the `--no-git-reset` option with `release:ci`, so the
working directory will be dirty regardless, so it's fine to modify
the changelog too (and it means changelog generation has CI coverage)
Finally, some of the other release process steps have been converted to
package.json scripts to simplify the steps.
Fixes #762.
edmorley
commented
Apr 13, 2019
| @@ -15,16 +15,20 @@ | |||
| "packages/*" | |||
| ], | |||
| "scripts": { | |||
| "changelog": "auto-changelog --latest-version $(yarn -s print-version)", | |||
There was a problem hiding this comment.
The use of bash subcommands ($(...)) makes this command not compatible with Windows (same as before this change, albeit now for a different reason), however this can be resolved by fixing cookpete/auto-changelog#106.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using auto-changelog's
--packageoption, which does not work with Lerna monorepos, since there is no version in the repo rootpackage.json. Now the version is instead read fromlerna.json.In addition,
SKIP_CHANGELOGhas been removed, since:(a) using environment variables in package.json scripts makes them incompatible with Windows
(b) we now use the
--no-git-resetoption withrelease:ci, so the working directory will be dirty regardless, so it's fine to modify the changelog too (and it means changelog generation has CI coverage)Finally, some of the other release process steps have been converted to package.json scripts to simplify the steps.
Fixes #762.