Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: migrate requirement files to PEP 735 dependency groups #279

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

neutrinoceros
Copy link
Owner

No description provided.

@neutrinoceros neutrinoceros force-pushed the mnt/dependency-groups branch 2 times, most recently from fcb25a3 to 3d0d71c Compare October 26, 2024 09:37
@neutrinoceros
Copy link
Owner Author

neutrinoceros commented Oct 26, 2024

This mostly works but wheel building is now broken (checked by manually triggering the workflow).
What seems to be happening is that:

  • uv sync supports --(only-)group but doesn't allow specifying a custom location for the virtual env1, so it's basically useless in the context of cibuildwheel (which creates a virtual env in an arbitrary location, intentionally outside the project dir)
  • uv pip install doesn't support --(only-)group options. It's not clear to me at the moment if this is a temporary or permanent limitation.

I've opened pypa/cibuildwheel#2057 to ask for native support of dependency groups in cibuildwheel.

Footnotes

  1. I was wrong, this part is actually configurable via an env variable, but so far I can't make this work either

@neutrinoceros
Copy link
Owner Author

neutrinoceros commented Nov 23, 2024

This should be ready now thanks to the release of cibuildwheel 2.22

watch https://github.com/neutrinoceros/gpgi/actions/runs/11985331508

@neutrinoceros neutrinoceros marked this pull request as ready for review November 23, 2024 07:35
@neutrinoceros neutrinoceros merged commit a8ebcd8 into main Nov 23, 2024
23 checks passed
@neutrinoceros neutrinoceros deleted the mnt/dependency-groups branch November 23, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant