Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: test GPGI_PY_LIB #204

Merged
merged 1 commit into from
Jun 30, 2024
Merged

TST: test GPGI_PY_LIB #204

merged 1 commit into from
Jun 30, 2024

Conversation

neutrinoceros
Copy link
Owner

Follow up to #202
Some tests currently fail with GPGI_PY_LIB so I'll try to fix that here.

@neutrinoceros neutrinoceros force-pushed the tst/py_lib branch 2 times, most recently from abea02d to 38df723 Compare June 29, 2024 10:55
@neutrinoceros
Copy link
Owner Author

I think I opened a can of worms. I need to make up my mind about

  • actually supporting infinitly large bounding box (doesn't seem worth the effort and potential perf cost)
  • allowing ds.deposit to be called when user doesn't supply cell edges

@neutrinoceros neutrinoceros force-pushed the tst/py_lib branch 5 times, most recently from 7deabd9 to c73e5a9 Compare June 30, 2024 14:02
@neutrinoceros
Copy link
Owner Author

All hard problems were handled in other PRs, this is now left with just enabling the new test job.

@neutrinoceros neutrinoceros marked this pull request as ready for review June 30, 2024 14:46
@neutrinoceros neutrinoceros merged commit 8136e00 into main Jun 30, 2024
15 checks passed
@neutrinoceros neutrinoceros deleted the tst/py_lib branch June 30, 2024 14:46
@neutrinoceros neutrinoceros added this to the v2.0.0 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@neutrinoceros