Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.isMaximized() returns false in linux right after calling themaximize() function #121

Open
Sadaf-A opened this issue Aug 15, 2024 · 3 comments · May be fixed by #150
Open

window.isMaximized() returns false in linux right after calling themaximize() function #121

Sadaf-A opened this issue Aug 15, 2024 · 3 comments · May be fixed by #150

Comments

@Sadaf-A
Copy link
Contributor

Sadaf-A commented Aug 15, 2024 •
edited
Loading

There is a similar issue with setFullScreen()
@Oshlok
Copy link

Oshlok commented Jan 12, 2025

Hey @Sadaf-A , Is this issue still valid because I just checked it & found everything working fine.

@Sadaf-A
Copy link
Contributor Author

Sadaf-A commented Jan 12, 2025

Hey @Sadaf-A , Is this issue still valid because I just checked it & found everything working fine.

You can add a test case to close this issue.
Thank you

shwetd19 added a commit to shwetd19/neutralino.js that referenced this issue Jan 27, 2025
@shwetd19
fix neutralinojs#121: Improved window state tracking for Linux systems
8b7cad6 
- added WindowStateManager to reliably track window states
- implementation of  state verification using window dimensions
- added some tolerance values for Linux window manager variations 
- fixed isMaximized() and setFullScreen() state detection
@shwetd19 shwetd19 linked a pull request Jan 27, 2025 that will close this issue
Open
@shwetd19
Copy link

Hey @Sadaf-A @shalithasuranga can you please review my PR regarding this here , as I'm new in this org I'm making myself familiar with the codebase, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #121: Improved window state tracking for Linux systems shwetd19/neutralino.js
3 participants
@Sadaf-A @shwetd19 @Oshlok