-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] filter signals with missing data #839
[Feature] filter signals with missing data #839
Conversation
I wonder, should we have a warning at this stage if missing samples are detected (or a certain proportion of missing samples)? Or only have warnings in specific feature extraction functions? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #839 +/- ##
==========================================
+ Coverage 53.88% 53.95% +0.06%
==========================================
Files 295 295
Lines 13811 13820 +9
==========================================
+ Hits 7442 7456 +14
+ Misses 6369 6364 -5
☔ View full report in Codecov by Sentry. |
Mmh good question... any preference? |
Not really, I noticed that there is already a warning in NeuroKit/neurokit2/ecg/ecg_clean.py Lines 89 to 96 in 1170887
So I guess to avoid being repetitive we can leave it out for now. |
Sounds good, feel free to merge |
Description
As a step towards better handling of missing data (see #838), this PR aims to allow for filtering signals even if they contain NaNs.
Proposed Changes
signal_filter()
function so that NaNs are interpolated before filtering and then added back after filtering.test_signal_filter_with_missing()
to test that the signal containing NaNs is filtered.Checklist