[docs] window size for locreg detrending

[vasileermicioi]

New PR as a follow-up of the discussion here #734

[codecov-commenter]

Codecov Report

Base: 52.88% // Head: 53.00% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (c900b75) compared to base (520231a).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #747      +/-   ##
==========================================
+ Coverage   52.88%   53.00%   +0.12%     
==========================================
  Files         290      291       +1     
  Lines       13037    13128      +91     
==========================================
+ Hits         6894     6958      +64     
- Misses       6143     6170      +27     

Impacted Files	Coverage Δ
neurokit2/signal/signal_detrend.py	39.68% <ø> (ø)
neurokit2/rsp/rsp_eventrelated.py	75.40% <0.00%> (-24.60%)	⬇️
neurokit2/rsp/rsp_amplitude.py	73.33% <0.00%> (-16.67%)	⬇️
neurokit2/rsp/rsp_simulate.py	93.75% <0.00%> (-0.90%)	⬇️
neurokit2/rsp/rsp_rrv.py	64.28% <0.00%> (ø)
neurokit2/rsp/__init__.py	100.00% <0.00%> (ø)
neurokit2/rsp/rsp_phase.py	100.00% <0.00%> (ø)
neurokit2/rsp/rsp_process.py	100.00% <0.00%> (ø)
neurokit2/rsp/rsp_symmetry.py	72.00% <0.00%> (ø)
neurokit2/eda/eda_eventrelated.py	83.67% <0.00%> (+2.04%)	⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[danibene]

I think we shouldn't multiply window or stepsize by the sample rate because that's already done within the function

[vasileermicioi]

if I don't multiply by sampling_rate I get an error 'stepsize' should be more than 1. Increase its value

nk.signal_detrend(sig, method="locreg", window=0.5, stepsize=0.1)

nk.__version__ is 0.2.1

[danibene]

if I don't multiply by sampling_rate I get an error 'stepsize' should be more than 1. Increase its value

nk.signal_detrend(sig, method="locreg", window=0.5, stepsize=0.1)

nk.__version__ is 0.2.1

@vasileermicioi have you tried with the dev branch? That the sampling rate is multiplied within the function is a new change since 0.2.1: #730

[DominiqueMakowski]

@danibene perhaps if it's easier (instead of having @vasileermicioi fiddling with the branches) you can commit the edits and merge?

[welcome]

Congrats on merging your first pull request! 🎉🍾 We're looking forward to your next one!