Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix typo in hrv_time #676

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Conversation

KSCzzZ
Copy link
Contributor

@KSCzzZ KSCzzZ commented Jul 14, 2022

The feature name in the comment is hcvnn, but the code is mcvnn

This is a template for making a pull-request. You can remove the text and sections and write your own thing if you wish, just make sure you give enough information about how and why. If you have any issues or difficulties, don't hesitate to open an issue so we can help.

Description

This PR aims at adding this feature...

Proposed Changes

I changed the foo() function so that ...

Checklist

Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

  • I have read the CONTRIBUTING file.
  • My PR is targetted at the dev branch (and not towards the master branch).
  • I ran the CODE CHECKS on the files I added or modified and fixed the errors.
  • I have added the newly added features to News.rst (if applicable)

The feature name in the comment is hcvnn, but the code is mcvnn
@welcome
Copy link

welcome bot commented Jul 14, 2022

Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 force
Make sure to read the contributing guide. Also, if you think that your contribution is worthy of it, you can consider adding yourself to the Contributors list (feel free to ask us if you have any doubts).

@DominiqueMakowski
Copy link
Member

Good catch @KSCzzZ, the failing tests are unlikely due to this change, so I'll merge this now :)

@DominiqueMakowski DominiqueMakowski changed the title Update hrv_time.py [Docs] Fix typo in hrv_time Jul 14, 2022
@DominiqueMakowski DominiqueMakowski merged commit 0419561 into neuropsychology:dev Jul 14, 2022
@welcome
Copy link

welcome bot commented Jul 14, 2022

landing
Congrats on merging your first pull request! 🎉🍾 We're looking forward to your next one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants