Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-annex: add configuration setting [annex].ENABLED #18

Merged
merged 2 commits into from
Sep 19, 2022
Merged

git-annex: add configuration setting [annex].ENABLED #18

merged 2 commits into from
Sep 19, 2022

Conversation

kousu
Copy link
Member

@kousu kousu commented Sep 19, 2022

Fixes #8

@kousu
Copy link
Member Author

kousu commented Sep 19, 2022

Corresponding patch to the related ansible deployment: https://github.com/neuropoly/computers/pull/420

@kousu kousu mentioned this pull request Sep 19, 2022
Merged
@kousu kousu requested a review from mguaypaq September 19, 2022 16:27
@kousu
Copy link
Member Author

kousu commented Sep 19, 2022

This should be an easy review, @mguaypaq, if you have some time to put towards it.

I've put this underneath #6 though, so it's blocking that at the moment.

mguaypaq
mguaypaq approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one tiny suggestion below.

custom/conf/app.example.ini
Comment on lines +2363 to +2370
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;[annex]
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;
;; Whether git-annex is enabled; defaults to false
;ENABLED = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this bit of documentation through example files!

modules/setting/annex.go Outdated Show resolved Hide resolved
@kousu @mguaypaq
Update modules/setting/annex.go
3d02945 
Co-authored-by: Mathieu Guay-Paquet <[email protected]>
@kousu kousu merged this pull request into git-annex Sep 19, 2022
@kousu kousu deleted the git-annex-setting branch September 19, 2022 21:22
@kousu
Copy link
Member Author

kousu commented Sep 19, 2022

Thanks for the review!

gitea-sync bot pushed a commit that referenced this pull request Sep 20, 2022
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
571c912 
* git-annex: add configuration setting [annex].ENABLED

Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
@kousu kousu mentioned this pull request Sep 20, 2022
Closed
kousu added a commit that referenced this pull request Oct 19, 2023
@kousu @mguaypaq
git-annex: add configuration setting [annex].ENABLED (#18)
f46fc88 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
gitea-sync bot pushed a commit that referenced this pull request Oct 30, 2023
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
8312d54 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
gitea-sync bot pushed a commit that referenced this pull request Oct 31, 2023
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
0d1ebf8 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
gitea-sync bot pushed a commit that referenced this pull request Nov 1, 2023
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
fde1d37 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
gitea-sync bot pushed a commit that referenced this pull request Nov 2, 2023
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
8a11ea6 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
kousu added a commit that referenced this pull request Nov 4, 2023
@kousu @mguaypaq
git-annex: add configuration setting [annex].ENABLED (#18)
83f4675 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
gitea-sync bot pushed a commit that referenced this pull request Nov 5, 2023
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
041dd0e 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
gitea-sync bot pushed a commit that referenced this pull request Nov 6, 2023
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
cbd7062 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
gitea-sync bot pushed a commit that referenced this pull request Nov 7, 2023
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
49924d8 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
gitea-sync bot pushed a commit that referenced this pull request Nov 8, 2023
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
39e65a0 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
gitea-sync bot pushed a commit that referenced this pull request Nov 9, 2023
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
081a4bd 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
gitea-sync bot pushed a commit that referenced this pull request Nov 10, 2023
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
ffd658c 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
gitea-sync bot pushed a commit that referenced this pull request Nov 11, 2023
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
77ee4b9 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
gitea-sync bot pushed a commit that referenced this pull request Nov 12, 2023
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
ecca857 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
gitea-sync bot pushed a commit that referenced this pull request Nov 13, 2023
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
04c85e7 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
gitea-sync bot pushed a commit that referenced this pull request Nov 14, 2023
@kousu @mguaypaq @actions-user
git-annex: add configuration setting [annex].ENABLED (#18)
08445ff 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
kousu added a commit that referenced this pull request Nov 20, 2023
@kousu @mguaypaq
git-annex: add configuration setting [annex].ENABLED (#18)
4231431 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
kousu added a commit that referenced this pull request Nov 29, 2023
@kousu @mguaypaq
git-annex: add configuration setting [annex].ENABLED (#18)
1c99330 
Fixes #8

Co-authored-by: Mathieu Guay-Paquet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguaypaq mguaypaq mguaypaq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kousu @mguaypaq