Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] segmentation api #213

Merged
merged 7 commits into from
Mar 5, 2022
Merged

[WIP] segmentation api #213

merged 7 commits into from
Mar 5, 2022

Conversation

Hoda1394
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

Checklist

  • I have added tests to cover my changes
  • I have updated documentation (if necessary)

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

@Hoda1394
Copy link
Contributor Author

I have some confusion about the object itself.

  1. what variables we should consider for instantiating the estimator object? (here the segmentation case)
  2. it seems that predict also should be a function rather than a method like the evaluate function?

@satra satra merged commit 9d99719 into neuronets:enh/api Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants