Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Allow multichannel input #177

Merged
merged 9 commits into from
Nov 8, 2021
Merged

Conversation

richford
Copy link
Contributor

@richford richford commented Sep 16, 2021

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

This PR adds support for multichannel input in get_dataset and all necessary supporting functions. It also adds support for remote storage using fsspec.

I wrote this mainly for my own use but I think it might be more broadly useful upstream as well, provided we can align it with the vision of the main nobrainer devs.

Checklist

  • I have added tests to cover my changes
  • I have updated documentation (if necessary)

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

@richford
Copy link
Contributor Author

Resolves #176

@Aakanksha-Rana
Copy link
Member

Aakanksha-Rana commented Sep 21, 2021

Thanks @richford. I will review this. Could you please add tests for these added functionalities?

@richford
Copy link
Contributor Author

Hi @Aakanksha-Rana, thanks! I added some tests for volume.py and io.py. I'll add further tests for the added functionality in transform.py and datasets.py later (probably next week). I also added tests for the pre-existing functions in volume.py.

@richford
Copy link
Contributor Author

Hi @Aakanksha-Rana, I just added remaining tests for transform.py and dataset.py. I think this is ready for review.

Also, I added myself to "contributors" in .zenodo.json. I know different projects like to include code contributors in .zenodo.json in different places (e.g. in "contributors" vs "creators") but I wasn't sure what the nobrainer convention is. If you'd like me to move the entry into "creators" or use a type other than "Researcher", just let me know and I'm happy to make the change.

Copy link
Member

@Aakanksha-Rana Aakanksha-Rana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @richford

@satra satra merged commit e97c4c2 into neuronets:master Nov 8, 2021
@richford richford deleted the enh/four-d branch November 8, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants