-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Allow multichannel input #177
Conversation
Resolves #176 |
Thanks @richford. I will review this. Could you please add tests for these added functionalities? |
6aa9c7d
to
5286337
Compare
Hi @Aakanksha-Rana, thanks! I added some tests for volume.py and io.py. I'll add further tests for the added functionality in transform.py and datasets.py later (probably next week). I also added tests for the pre-existing functions in volume.py. |
Hi @Aakanksha-Rana, I just added remaining tests for Also, I added myself to "contributors" in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @richford
Types of changes
Summary
This PR adds support for multichannel input in
get_dataset
and all necessary supporting functions. It also adds support for remote storage usingfsspec
.I wrote this mainly for my own use but I think it might be more broadly useful upstream as well, provided we can align it with the vision of the main nobrainer devs.
Checklist
Acknowledgment