Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter to drop examples (blocks) which are uniform (all zeros) #336

Open
hvgazula opened this issue Jun 7, 2024 · 2 comments
Open

Add filter to drop examples (blocks) which are uniform (all zeros) #336

hvgazula opened this issue Jun 7, 2024 · 2 comments
Assignees
@hvgazula

Comments

@hvgazula
Copy link
Contributor

hvgazula commented Jun 7, 2024

What would you like changed/added and why?
Currently, all blocks are included in training. We should remove dropping blocks which are all zeros as training on them is redundant.

What would be the benefit?
Faster training.

Does the change make something easier to use?
see above.
@hvgazula hvgazula self-assigned this Jun 7, 2024
hvgazula added a commit that referenced this issue Jun 10, 2024
@hvgazula
resolved #336
f0396cb
@hvgazula
Copy link
Contributor Author

check how does this fit with #219

@hvgazula hvgazula reopened this Jun 10, 2024
@hvgazula
Copy link
Contributor Author

this conflicts with pgan generation.. see #339

@hvgazula hvgazula mentioned this issue Jun 19, 2024
Open
@hvgazula hvgazula mentioned this issue Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvgazula hvgazula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hvgazula