Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --name in all other neuro commands #648

Merged
merged 8 commits into from
Apr 3, 2019

Conversation

atemate
Copy link
Contributor

@atemate atemate commented Mar 18, 2019

Resolve job name to job ID in all job-commands.

@atemate atemate requested review from asvetlov and shagren March 18, 2019 15:29
@atemate atemate force-pushed the ay/job-name-interchangeable branch from 87e3ed5 to b91e515 Compare March 18, 2019 15:30
@atemate atemate changed the title [WIP] Add support for --name in all other neuro commands Add support for --name in all other neuro commands Mar 18, 2019
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #648 into master will increase coverage by 1.56%.
The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
+ Coverage   90.25%   91.82%   +1.56%     
==========================================
  Files          39       39              
  Lines        3172     3194      +22     
  Branches      432      433       +1     
==========================================
+ Hits         2863     2933      +70     
+ Misses        237      198      -39     
+ Partials       72       63       -9
Impacted Files Coverage Δ
neuromation/cli/utils.py 92.13% <100%> (+1.83%) ⬆️
neuromation/cli/formatters/jobs.py 99.52% <100%> (+0.96%) ⬆️
neuromation/cli/job.py 90.86% <91.3%> (+0.33%) ⬆️
neuromation/cli/main.py 59.89% <0%> (+0.52%) ⬆️
neuromation/cli/rc.py 93.56% <0%> (+0.99%) ⬆️
neuromation/client/storage.py 100% <0%> (+2.36%) ⬆️
neuromation/client/images.py 99.04% <0%> (+2.85%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac34672...c09bafc. Read the comment docs.

@atemate
Copy link
Contributor Author

atemate commented Mar 19, 2019

decrease in coverage is due to changes in cli/job.py methods which we don't test directly

python/neuromation/cli/job.py Outdated Show resolved Hide resolved
python/neuromation/cli/job.py Outdated Show resolved Hide resolved
python/neuromation/client/jobs.py Outdated Show resolved Hide resolved
python/neuromation/client/jobs.py Outdated Show resolved Hide resolved
python/neuromation/client/jobs.py Outdated Show resolved Hide resolved
@atemate atemate force-pushed the ay/job-name-interchangeable branch 3 times, most recently from bea5c65 to 031647b Compare March 26, 2019 18:17
@atemate atemate requested a review from asvetlov March 26, 2019 18:21
@atemate atemate self-assigned this Mar 26, 2019
@atemate atemate force-pushed the ay/job-name-interchangeable branch 3 times, most recently from 9781beb to b3a8ca1 Compare April 2, 2019 15:38
@atemate atemate force-pushed the ay/job-name-interchangeable branch from b3a8ca1 to 21e2647 Compare April 3, 2019 09:14
@atemate atemate force-pushed the ay/job-name-interchangeable branch from 21e2647 to 130f535 Compare April 3, 2019 13:10
neuromation/cli/job.py Outdated Show resolved Hide resolved
@atemate atemate merged commit b7c7e77 into master Apr 3, 2019
@atemate atemate deleted the ay/job-name-interchangeable branch April 3, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants