Add support for neuro job list --name #633
Conversation
atemate
changed the title
atemate
force-pushed
the
ay/job-name-list
branch
2 times, most recently
from
a2cfde9 to
5916c5e
Compare
atemate
changed the title
|
Note: maybe the server should return sorted list of jobs with specified name, and the client should choose the last chronologically sorted one. Not doing GET /jobs?name=n&status=failed&status=pending. |
atemate
force-pushed
the
ay/job-name-list
branch
3 times, most recently
from
fe982f1 to
8c496ac
Compare
atemate
force-pushed
the
ay/job-name-list
branch
2 times, most recently
from
3abd598 to
b460ba7
Compare
|
The Codecov is broken: it does not show exact lines where we have lost coverage. The coverage decreased because of |
| @@ -203,6 +204,7 @@ def from_job( | |||
| when_humanized = humanize.naturaldate(when_datetime) | |||
| return cls( | |||
| id=job.id, | |||
| name=job.name if job.name else "", | |||
There was a problem hiding this comment.
name: str is not optional, thus it is never None. should be passed as is, or the type should be changed.
There was a problem hiding this comment.
actually, the class of JobDescription has name: Optional[str] = None. When working on the field name I mostly followed the pattern of how the field JobDescription.description is implemented: Optional[str] for JobDescription and str for formatters (TabularJobRow and others).
So left this unchanged.
atemate
force-pushed
the
ay/job-name-list
branch
from
f932f22 to
a7dfc39
Compare
atemate
force-pushed
the
ay/job-name-list
branch
from
4507162 to
a5c226e
Compare
atemate
force-pushed
the
ay/job-name-list
branch
from
a5c226e to
0b88e2e
Compare
we update note only on the last PR that implements job names so that no one will start using job-names until they are fully supported |
already 😉 |
atemate
dismissed
shagren’s stale review
dismiss because don't see the re-request button
Support
neuro ps --name {job-name}