Run CLI on Windows #548
Merged
Run CLI on Windows #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
+ Coverage 91.09% 91.28% +0.18%
==========================================
Files 40 40
Lines 3021 3040 +19
Branches 393 398 +5
==========================================
+ Hits 2752 2775 +23
+ Misses 202 200 -2
+ Partials 67 65 -2Continue to review full report at Codecov.
|
dalazx
reviewed
Feb 28, 2019
| @@ -18,6 +19,10 @@ | |||
| from .utils import Context, DeprecatedGroup, MainGroup, alias, format_example | |||
|
|
|||
|
|
|||
| if sys.platform == "win32": | |||
There was a problem hiding this comment.
Suggested change
| if sys.platform == "win32": | |
| if WIN32: |
minor.
There was a problem hiding this comment.
The constant is intentional: mypy calculates explicit constant comparison correctly but skips the second version.
This was referenced Feb 28, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.